Ticket #922 (new enhancement)

Opened 14 months ago

Last modified 14 months ago

Mix of translated and untranslated message

Reported by: goeran Owned by: lennart
Milestone: Component: clients
Keywords: Cc: mkbosmans@…

Description

In src/utils/pacat.c there is this code:

pa_log(_("Connected to device %s (%u, %ssuspended)."),
        pa_stream_get_device_name(s),
        pa_stream_get_device_index(s),
        pa_stream_is_suspended(s) ? "" : "not ");

The word "not" is not available for translation here. And building messages from pieces in this way often breaks translations. I'm sure there are some language where the word "suspended" should have different forms depending on whether it is negated or not.

I making two complete messages instead, and selecting the entire message based on the return value of pa_stream_is_suspended().

Change History

Changed 14 months ago by mkbosmans

  • cc mkbosmans@… added
  • type changed from defect to enhancement

If someone is going over the source code and review for translation difficulties, then please also look at pa_yes_no in pulsecore/core-util.c. Those little two strings should be translated also.

Perhaps that's even a possible solution here:

pa_log(_("Connected to device %s (%u, suspended: %s)."),
        pa_stream_get_device_name(s),
        pa_stream_get_device_index(s),
        pa_yes_no(pa_stream_is_suspended(s));
Note: See TracTickets for help on using tickets.