Ticket #843 (closed defect: fixed)

Opened 19 months ago

Last modified 15 months ago

Some PA strings are not translated in the Gnome Sound Properties window

Reported by: kelemeng Owned by: lennart
Milestone: 0.9.22 Component: module-alsa-*
Keywords: i18n Cc:

Description

There are some user visible strings in the Gnome Sound Preferences window, that are from PA and altough they are translated in PA's po file, they do not show up translated: http://people.ubuntu.com/~kelemeng/pix/soundprefs.png

These are the device descriptions shown in the Hardware, Input and Output tabs, in the Choose a device... fields and in the dropdown lists.

Attached patch fixes this problem: http://people.ubuntu.com/~kelemeng/pix/soundprefs-fixed.png

Attachments

translate-array-elements.patch (365 bytes) - added by kelemeng 19 months ago.
Simple patch to call gettext on array elements
translate-strings.patch (0.8 kB) - added by kelemeng 19 months ago.
Mark two strings for translation, these are visible there too

Change History

Changed 19 months ago by kelemeng

Simple patch to call gettext on array elements

Changed 19 months ago by kelemeng

Mark two strings for translation, these are visible there too

follow-up: ↓ 2   Changed 19 months ago by coling

Hi there.

Thanks loads for the translation work. It's much appreciated. If you get the chance, can you submit them via the Transiflex service. This is how translations are handled and dished out to the community in PA so as to avoid duplication and streamline the process etc!

http://pulseaudio.org/wiki/Community#BugsPatchesTranslations

https://www.transifex.net/projects/p/pulseaudio/c/master-tx/

If you are not able to do this, then please let us know and someone will do it manually for you.

in reply to: ↑ 1   Changed 19 months ago by kelemeng

Replying to coling:

If you are not able to do this, then please let us know and someone will do it manually for you.

I'm not able to submit code patches via Transifex, because it was invented for handling translations, not source code. So yes, please push them manually :).

  Changed 19 months ago by coling

Cool, no worries. It may take a while as I'll need to work out how to merge in the latest transiflex stuff reliably first then apply your patch then push both out... not done that before, but I'll prod the folk that do so I can learn :D

  Changed 19 months ago by kelemeng

In theory, Transifex is fully automatic, so you don't have to do anything with it. If you commit new strings to the repository, Transifex updates it's copy of the repository and generates updated po files for us, also when we update them, it commits the files to the upstream repository, so you don't have to worry about it. This is why many developers like and use it :).

But: this problem has nothing to do with translation files. The problem is that strings are translated in the po files, but the program does not pick them up. First patch fixes this, see also: http://www.gnu.org/software/gettext/manual/gettext.html#Special-cases

The second is just some more strings that are forgotten to mark for translation (the Input and Output words on my first screenshot after "Analog Stereo") - I was just lazy to open another ticket.

  Changed 19 months ago by coling

I'm just now quite sure where the transiflex branch master-tx currently stands vs. master. I know it needs a merge, but I've not done that yet.... Anyway, I should have read your patches first before assuming they were plain translations :) Will try and take a look soon :D

  Changed 19 months ago by coling

Gah, s/now/not/... pah! Go-go-gadget opposite-meaning-typo

  Changed 17 months ago by kelemeng

Ping?

  Changed 15 months ago by lennart

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.9.22

Applied in stable-queue. This will be part of the next release.

Note: See TracTickets for help on using tickets.