Ticket #818 (closed defect: fixed)

Opened 21 months ago

Last modified 21 months ago

syntax error in rtp.c

Reported by: pino Owned by: lennart
Milestone: Component: module-rtp-*
Keywords: Cc:

Description

In the pa_rtp_recv() function of rtp.c there is:

for (cm = CMSG_FIRSTHDR(&m); cm; cm = CMSG_NXTHDR(&m, cm)) {

if (cm->cmsg_level == SOL_SOCKET && cm->cmsg_type == SO_TIMESTAMP)

memcpy(tstamp, CMSG_DATA(cm), sizeof(struct timeval)); found_tstamp = TRUE; break;

}

There is one opening and one closing brackets less, so the loop will set found_tstamp TRUE and break just after the first iteration, no matter whether the current cmsghdr had the right payload.

Change History

Changed 21 months ago by coling

Oooh, good catch. I'll get that fixed up in a mo'

Changed 21 months ago by coling

  • status changed from new to closed
  • resolution set to fixed

Fixed now in stable-queue and I'll push to master shortly. Many thanks for the report.

Note: See TracTickets for help on using tickets.