pa_cvolume_inc allows to set volume over PA_VOLUME_NORM

[matrix47]

this function is used to increase volume from module-lirc and module-mmkbd-evdev
right now volume can be increased up to PA_VOLUME_MAX, which is VERY loud
I think it is more reasonable to limit the volume with PA_VOLUME_NORM (100%)
trivial patch attached

[matrix47]

patch

[lennart]

Hmm, no, I disagree. We explicitly allow volumes > PA_VOLUME_NORM for digital amplification. In fact we have been exposing digital amplification for recording in g-v-c already and I have been recommending for a while to extend the output volume control volume sliders to "150%", too, so that people can make use of this.

So, generally limiting the range to PA_VOLUME_NORM is not really something I'd like to merge. However I would accept a patch that adds module parameters to m-l and m-m-e that allow specification of an upper limit up to which one may increase the volume with these modules. We could even enable that by default and set it to PA_VOLUME_NORM*3/2, or so.

[matrix47]

these two patches seem to do the job I've added parameters volume_limit and volume_step to lirc and mmkbd modules the first one sets the limit for maximum volume the module can set, defaults to PA_VOLUME_NORM*3/2 (so, by default volume can be raised up to 150%) the second one sets volume change step, defaults to PA_VOLUME_NORM/20

[lennart]

Looks good. Will merge early in the next cycle.

[lennart]

This got merged a while back:

http://git.0pointer.de/?p=pulseaudio.git;a=commit;h=7793da371bbf70e23c0b45de1e188f5dd58f3324

http://git.0pointer.de/?p=pulseaudio.git;a=commit;h=d2c59354d554f136739be7bbcd326f1d254f778e