module-tunnel-sink segfaults without sink argument set

[matthijs]

I've been toying around with module-tunnel a bit, and found it segfaulted when I tried it. I'm using 0.9.8, but module-tunnel hasn't been modified since that release AFAICS.

After finally getting gdb to work, I found that the problem lies at module-tunnel.c:698

    if (strcmp(name, u->sink_name))

Here, u->sink_name is NULL. Some tracing back leads me to module-tunnel.c:1274

    u->sink_name = pa_xstrdup(pa_modargs_get_value(ma, "sink", NULL));;

So, the problem was that I didn't specify a "sink" argument to module-tunnel-sink. Adding the sink argument, seems to make the module work (though I have no full testing setup here).

Still, this is a problem in the source code. It should either complain about a missing "sink" option, or properly handle the lack of a "sink" option. Perhaps it should use the first available sink or something?

[lennart]

(In [2186]) don't segfault when module-tunnel is used without a sink_name/source_name parameter. Closes #197