libpolyp.la needs to link to -liconv when compiling with MinGW

[polypaudio@…]

When attempting to compile polypaudio under MinGW, the following error occurs:

[...]
/opt/xmingw/bin/i386-mingw32msvc-gcc -shared  .libs/libpolyp_la-channelmap.o .libs/libpolyp_la-client-conf.o .libs/libpolyp_la-context.o .libs/libpolyp_la-error.o .libs/libpolyp_la-introspect.o .libs/libpolyp_la-mainloop.o .libs/libpolyp_la-mainloop-api.o .libs/libpolyp_la-mainloop-signal.o .libs/libpolyp_la-operation.o .libs/libpolyp_la-sample.o .libs/libpolyp_la-scache.o .libs/libpolyp_la-stream.o .libs/libpolyp_la-subscribe.o .libs/libpolyp_la-thread-mainloop.o .libs/libpolyp_la-timeval.o .libs/libpolyp_la-utf8.o .libs/libpolyp_la-util.o .libs/libpolyp_la-volume.o .libs/libpolyp_la-xmalloc.o .libs/libpolyp_la-authkey.o .libs/libpolyp_la-conf-parser.o .libs/libpolyp_la-core-util.o .libs/libpolyp_la-dynarray.o .libs/libpolyp_la-hashmap.o .libs/libpolyp_la-idxset.o .libs/libpolyp_la-iochannel.o .libs/libpolyp_la-log.o .libs/libpolyp_la-mcalign.o .libs/libpolyp_la-memblock.o .libs/libpolyp_la-memblockq.o .libs/libpolyp_la-memchunk.o .libs/libpolyp_la-packet.o .libs/libpolyp_la-parseaddr.o .libs/libpolyp_la-pdispatch.o .libs/libpolyp_la-pipe.o .libs/libpolyp_la-poll.o .libs/libpolyp_la-pstream.o .libs/libpolyp_la-pstream-util.o .libs/libpolyp_la-queue.o .libs/libpolyp_la-random.o .libs/libpolyp_la-socket-client.o .libs/libpolyp_la-socket-util.o .libs/libpolyp_la-strbuf.o .libs/libpolyp_la-strlist.o .libs/libpolyp_la-tagstruct.o .libs/libpolyp_la-core-error.o .libs/libpolyp_la-dllmain.o  -L/opt/xmingw/lib -lwsock32 -lws2_32 -lwininet  -Wl,--export-all-symbols -o .libs/libpolyp-0.dll -Wl,--enable-auto-image-base -Xlinker --out-implib -Xlinker .libs/libpolyp.dll.a
Creating library file: .libs/libpolyp.dll.a
.libs/libpolyp_la-utf8.o: In function `iconv_simple':/var/tmp/polypaudio/src/polyp/utf8.c:181: undefined reference to `_libiconv_open'
:/var/tmp/polypaudio/src/polyp/utf8.c:195: undefined reference to `_libiconv'
:/var/tmp/polypaudio/src/polyp/utf8.c:213: undefined reference to `_libiconv_close'
collect2: ld returned 1 exit status

the patch is as follows:

Index: configure.ac
===================================================================
--- configure.ac        (revision 999)
+++ configure.ac        (working copy)
@@ -219,6 +219,9 @@
 # BSD
 AC_SEARCH_LIBS([connect], [socket])

+# iconv
+AM_ICONV
+
 # Non-standard

 # This magic is needed so we do not needlessly add static libs to the win32
Index: src/Makefile.am
===================================================================
--- src/Makefile.am     (revision 999)
+++ src/Makefile.am     (working copy)
@@ -418,7 +418,7 @@

 libpolyp_la_CFLAGS = $(AM_CFLAGS)
 libpolyp_la_LDFLAGS = -version-info $(LIBPOLYP_VERSION_INFO)
-libpolyp_la_LIBADD = $(AM_LIBADD) $(WINSOCK_LIBS)
+libpolyp_la_LIBADD = $(AM_LIBADD) $(WINSOCK_LIBS) $(LIBICONV)

 if HAVE_X11
 libpolyp_la_CFLAGS += $(X_CFLAGS)

[lennart]

A side note: you can attach files (including patch files) to a Trac Ticket after you created the ticket. It's much easier for us to merge such an attachment than and inline quoting.

[polypaudio@…]

I just tried to add an attachment, but I get the error

OSError: [Errno 13] Permission denied: '/home/lennart/svn/trac/polypaudio/attachments/ticket'.

[ossman]

closed by r1012

[lennart]

A side node: adding attachments should work now.