Ticket #185 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

conf-parser and cli-command limit line length to 256

Reported by: kritzstapf Owned by: lennart
Milestone: Component: core
Keywords: conf-parser line length Cc:

Description

Using channel maps with a large amount of channels can cause lines longer than 256 chars. The parser fails to read those lines because they are safed in char array of length 256.

Example

# channel test sink

load-module module-remap-sink sink_name=channeltest master=surround master_channel_map=front-left,front-right,rear-left,rear-right,side-left,side-right,center,subwoofer channel_map=front-left,front-left,front-left,front-left,front-left,front-left,front-left,front-left channels=8

Fix

change line 129 of conf-parser.c to create a larger array:

129:        char l[256];
129:        char l[1024]; // that should be enough

Change History

Changed 4 years ago by kritzstapf

  • summary changed from conf-parser limits line length to 256 to conf-parser and cli-command limit line length to 256

CLI Fix

change line 1366 of cli-command.c to create a larger array:

1336:    char line[256];
1336:    char line[1024];

Changed 4 years ago by tanuk

  • status changed from new to closed
  • resolution set to fixed

Fixed in revision 2084. I didn't increase the limit in conf-parser.c, because the .conf files don't need as long lines as default.pa.

Note: See TracTickets for help on using tickets.