Ticket #171 (closed defect: fixed)
pid file handling and --check not working when a pid clash occurs
| Reported by: | coling | Owned by: | lennart |
|---|---|---|---|
| Milestone: | Component: | daemon | |
| Keywords: | Cc: |
Description
When testing why a user's pulseaudio often fails to start I found some annoying issues with the pid file handling.
Using a user-specific daemon, it writes a pid file in /tmp/pulse-user/pid
While pulse will normally clean up this pid file on exit, there are some cases (it seems) when this fails to happen (not yet tracked this down, but a crash or power failure could presumably cause it).
If e.g. on next reboot, there is not any process with that process id then pulse will happily consider it stale and overwrite it. If however another, completely separate process exists with that pid, pulse will not start and pulseaudio --check will indicate it is running.
I think more stringent checks are needed to ensure the that process with that number is indeed a pulse process (and not the current one which could be an annoying oversight!!). If it is not a pulse process then it should be considered stale as above.
