Ticket #112 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

pavucontrol's Move Stream take multiple attempts to make it "stick"

Reported by: coling Owned by: lennart
Milestone: Component: pavucontrol
Keywords: Cc:

Description

Recently with PA 0.9.6 and pavucontrol 0.9.4 the "Move Stream" functionality does not seem to work reliably, often taking half a dozen or so "clicks" to actually move the stream.

The command line pactl seems to do it correctly (tho' took me ages to work out the syntax ;))

Does anyone else get this?

Attachments

pavucontrol-fix-move-stream-left-click.patch (406 bytes) - added by coling 4 years ago.
Finally find the issue.

Change History

Changed 5 years ago by coling

Doing a little digging it seems that the signal is just not getting fired. Looking for example of registering the signal and the code looks good so I'm guessing there must be something up with my GTK....

Changed 4 years ago by coling

Finally find the issue.

Changed 4 years ago by coling

It seems the popup menu only responded to right clicks not left ones. This was due to the fact that the value of 3 was passed in as an argument to the popup() method. I changed this to a 0 and the submenu now responds to left clicks as well as right and is more intuitive.

Changed 4 years ago by coling

Just noticed that the same problem exists in padevchooser. The menu pops up on both left and right clicks but you have to use the same button you used to activate the menu to then make your selection. By changing the value to 0 it works fine with both buttons. See here for a patch.

Changed 4 years ago by lennart

  • status changed from new to assigned

The pavucontrol patch is applied in r58.

Changed 4 years ago by lennart

  • status changed from assigned to closed
  • resolution set to fixed

I made the necessary changes in padevchooser now too in r34, although i didn't merge the patch unmodified. I had to make some updates because padevchooser from SVN now uses GtkStatusIcon?.

Thank you for your patches!

Note: See TracTickets for help on using tickets.